ISC6.x & PHP 5.5 work through
Posted: Wed Oct 22, 2014 11:05 am
As I'm still using this software for now and PHP5.5 has some significant improvements I'm working through the upgrade list assuming you're on PHP 5.4 (as we've dealt elsewhere with the problems that causes).
1. get_magic_quotes_runtime() and _gpc() now return false having been removed
Shouldn't affect anything and ISC seems to remove any magic quotes put in automagically anyway
2. register_globals disabled
Again should have been dealt with years ago so no apparent issues
3. Can't find any use of break or continue that involves variable calls.
4. Non-numeric string offsets is going to require a significant rewrite of existing code to replace:
isset() with array_key_exists as the code uses it extensively...
empty() is also going to need adjustment (to array['key'] == false) for any array['key'] checks as again it's used a lot.
5. array_combine() now returns an empty array() if the arrays are empty rather than false. Can't find any logic checks that use false instead of checking the array count but one to look out for.
6. Retired functions don't appear to be called but again need to watch out.
As it stands, point 4. means that the existing code is not PHP5.5 compatible and a significant rewrite of the code will be required before 6.x code can be used with PHP5.5.
1. get_magic_quotes_runtime() and _gpc() now return false having been removed
Shouldn't affect anything and ISC seems to remove any magic quotes put in automagically anyway
2. register_globals disabled
Again should have been dealt with years ago so no apparent issues
3. Can't find any use of break or continue that involves variable calls.
4. Non-numeric string offsets is going to require a significant rewrite of existing code to replace:
isset() with array_key_exists as the code uses it extensively...
empty() is also going to need adjustment (to array['key'] == false) for any array['key'] checks as again it's used a lot.
5. array_combine() now returns an empty array() if the arrays are empty rather than false. Can't find any logic checks that use false instead of checking the array count but one to look out for.
6. Retired functions don't appear to be called but again need to watch out.
As it stands, point 4. means that the existing code is not PHP5.5 compatible and a significant rewrite of the code will be required before 6.x code can be used with PHP5.5.